Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Intrinsic Matrix in data fetching, probably leading to worse IPMNet performance #21

Closed
Owen-Liuyuxuan opened this issue May 6, 2022 · 2 comments

Comments

@Owen-Liuyuxuan
Copy link

Thank you for your amazing work.

I notice that there is a resize operation in the data fetching phase that shrinks the image size.

However, to keep the projection relation between ground truth 3D lanes and the (resized)image pixels, we also need to adjust the camera intrinsic during the data fetching phase. (For example, if the image is downsampled by two, the first two rows of the intrinsic matrix should also become one half smaller)

In HDMapNet, because we use linear layers to learn the mapping between the front view and the BEV view, there is no need for intrinsic parameters, and the code works fine.

However, in IPMNet and Lift-Splat-Shoot, correct camera intrinsic parameters are essential to correctly project the FV features to BEV. The inconsistent camera intrinsic matrix could probably hurt the performance of IPMNet and LSS in the experiments mentioned in your paper. Did the ablation experiments in your paper also use the code in this repo to reproduce?

@Mrmoore98
Copy link
Collaborator

We have taken the effect of resize operation into consideration and updated the rotation and translation matrices here.

@Owen-Liuyuxuan
Copy link
Author

Thank you for your explanation... It seems that post_RT is not a rotation/translation but a scale factor matrix (it is also set to None at HDMap, which also misdirects me a bit).

The code flow seems correct after all. Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants