Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with gregic additions #565

Closed
kotelkonrad opened this issue Apr 15, 2019 · 10 comments
Closed

incompatible with gregic additions #565

kotelkonrad opened this issue Apr 15, 2019 · 10 comments
Labels
needs further info Needs more information to confirm the report

Comments

@kotelkonrad
Copy link

kotelkonrad commented Apr 15, 2019

Mod Version
What version of the mod are you on?
latest

To Reproduce
Steps to reproduce the behaviour:
install gregic additions and AoA

image
https://paste.dimdev.org/iqiyugecij.mccrash
TheLimePixel/GregicAdditions#59

@Tslat
Copy link
Owner

Tslat commented Apr 15, 2019

I need that crash report if you want anything done

@Tslat Tslat added the needs further info Needs more information to confirm the report label Apr 15, 2019
@kotelkonrad
Copy link
Author

kotelkonrad commented Apr 15, 2019

https://paste.dimdev.org/iqiyugecij.mccrash
this is crash report

@kotelkonrad
Copy link
Author

latest.log

@Tslat
Copy link
Owner

Tslat commented Apr 15, 2019

Doesn't look to be anything on my side.
I'm closing this for now, if the other dev finds anything that he believes is on my side, someone can let me know

@Tslat Tslat closed this as completed Apr 15, 2019
@kotelkonrad
Copy link
Author

ok

@kotelkonrad
Copy link
Author

image
without gregic additions, and with

@Tslat
Copy link
Owner

Tslat commented Apr 16, 2019

Yeah looks like on Gregic's side

@kotelkonrad
Copy link
Author

:(

@Shadows-of-Fire
Copy link

This is technically an error caused by an assumption on an automatic recipe processing system. It would be easier to have you fix it on your end.

Basically, your slabs don't use a 1x3 shaped recipe like they should, they use a 3x3 shaped recipe using empty spaces in the top and bottom slots, which makes it so the automatic processor (which grabs the first ingredient) finds the empty ingredient and errors out on Ingredient#getMatchingStacks.

If you switch your slab recipes to 1x3, not only will your slabs be craftable in the top and bottom rows of the table (mirroring expected behavior established by vanilla), the error will just vanish.

@Tslat
Copy link
Owner

Tslat commented Apr 17, 2019

Ah well that's already been done for 3.1 anyway, so if that's the problem there then it should be fine once that's out.

However I would still recommend you don't make the assumption, because there is valid reasons for not shrinking the crafting space to fit the recipe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs further info Needs more information to confirm the report
Projects
None yet
Development

No branches or pull requests

3 participants