Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slider style bug while set min max step #1670

Closed
Sepush opened this issue Nov 24, 2021 · 0 comments · Fixed by #1675
Closed

slider style bug while set min max step #1670

Sepush opened this issue Nov 24, 2021 · 0 comments · Fixed by #1675
Labels
bug Something isn't working

Comments

@Sepush
Copy link
Collaborator

Sepush commented Nov 24, 2021 •
edited
Loading

TuSimple/naive-ui version (版本)

2.21.1

Vue version (Vue 版本)

3.2.22

Browser and its version (浏览器及其版本)

96

System and its version (系统及其版本)

win10

Node version (Node 版本)

16

Reappearance link (重现链接)

https://codesandbox.io/s/zen-worker-m7kyu?file=/src/Demo.vue

Reappearance steps (重现步骤)

1 get to the reproduction URL
2 slide to the max and you will see the color didn't fill the slider
you can also find the reproduction in https://www.naiveui.com/zh-CN/os-theme/components/data-table#flex-height

Expected results (期望的结果)

color full fill the slider

Actual results (实际的结果)

the color does not fully fill it

Remarks (补充说明)
@github-actions github-actions bot added the untriaged need to sort label Nov 24, 2021
@Sepush Sepush changed the title slider style bug will set min max step slider style bug while set min max step Nov 24, 2021
@07akioni 07akioni added bug Something isn't working and removed untriaged need to sort labels Nov 24, 2021
nooooooom added a commit to nooooooom/naive-ui that referenced this issue Nov 24, 2021
@nooooooom
fix(tusen-ai#1670): fix fill style bug
9dc4809
@nooooooom nooooooom mentioned this issue Nov 24, 2021
Merged
07akioni pushed a commit that referenced this issue Nov 24, 2021
@nooooooom
fix(slider): fix fill style (#1675)
966773d 
* fix(#1670): fix fill style bug

* test(slider): add test

* chore(slider): change usage

* docs(slider): add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slider): fix fill style nooooooom/naive-ui
2 participants
@07akioni @Sepush