Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog open bug (still not fixed) #1877

Closed
flyingTodream opened this issue Dec 17, 2021 · 3 comments
Closed

Dialog open bug (still not fixed) #1877

flyingTodream opened this issue Dec 17, 2021 · 3 comments
Labels
bug Something isn't working priority: high

Comments

@flyingTodream
Copy link

TuSimple/naive-ui version (版本)

2.23.0

Vue version (Vue 版本)

3.2.26

Browser and its version (浏览器及其版本)

Chrome 版本 96.0.4664.110(正式版本) (arm64)

System and its version (系统及其版本)

MacOS(12.1)

Node version (Node 版本)

Reappearance link (重现链接)

https://codesandbox.io/s/immutable-moon-6hnm8?file=/src/Demo.vue

Reappearance steps (重现步骤)

  1. use the dialog component without 'positive-text' and 'negative-text'
  2. when the dialog is open
  3. press 'enter' or 'space' key
  4. open a new dialog and repeat

Expected results (期望的结果)

close the dialog

Actual results (实际的结果)

open a new dialog

Remarks (补充说明)

i have submit a issue yestoday, it was closed without fixed.
I saw the version released today, but it still not be fixed, I hope it can be resolved soon.

@github-actions github-actions bot added the untriaged need to sort label Dec 17, 2021
@Sepush
Copy link
Collaborator

Sepush commented Dec 17, 2021

the autofocus is dependent on the positive-text and negative-text so you should provide them

@07akioni
Copy link
Collaborator

This is a bug, I'll refactor it later.

@07akioni 07akioni added bug Something isn't working priority: high and removed untriaged need to sort labels Dec 17, 2021
@07akioni
Copy link
Collaborator

We should learn from this.
ref https://mui.com/components/dialogs/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high
Projects
None yet
Development

No branches or pull requests

3 participants