Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDrawer] set mask-closable = false will make close by "ESC" not work #2233

Closed
SparkGB opened this issue Jan 21, 2022 · 0 comments
Closed

[NDrawer] set mask-closable = false will make close by "ESC" not work #2233

SparkGB opened this issue Jan 21, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@SparkGB
Copy link

SparkGB commented Jan 21, 2022

TuSimple/naive-ui version (版本)

2.24.1

Vue version (Vue 版本)

3.2.27

Browser and its version (浏览器及其版本)

Chrome(96.0.4664.110)

System and its version (系统及其版本)

MacOS(12.0.1)

Node version (Node 版本)

Reappearance link (重现链接)

https://codesandbox.io/s/compassionate-kate-fxpg1?file=/src/Demo.vue

Reappearance steps (重现步骤)

  1. Click "Open" button to show the drawer.
  2. Click the "Mask" 1 time.
  3. Press "ESC".

Expected results (期望的结果)

Drawer will close after press "ESC".

Actual results (实际的结果)

Drawer still show on screen.

Remarks (补充说明)

Modal have same problem too.
https://codesandbox.io/s/2kyyz
@github-actions github-actions bot added the untriaged need to sort label Jan 21, 2022
@Talljack Talljack added bug Something isn't working and removed untriaged need to sort labels Jan 21, 2022
@nooooooom nooooooom mentioned this issue Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Drawer): can not be closed by Esc key nooooooom/naive-ui
2 participants
@SparkGB @Talljack