Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set min-width: 0 for n-button__content to prevent content overflowing the button #3178

Closed
wc-matteo opened this issue Jun 25, 2022 · 1 comment · Fixed by #3185
Closed

set min-width: 0 for n-button__content to prevent content overflowing the button #3178

wc-matteo opened this issue Jun 25, 2022 · 1 comment · Fixed by #3185
Labels
feature request New feature or request

Comments

@wc-matteo
Copy link

wc-matteo commented Jun 25, 2022 •
edited
Loading

This function solves the problem (这个功能解决的问题)

in this case: https://codesandbox.io/s/trusting-thompson-oh9czd?file=/src/Demo.vue

the content overflows the button. Setting min-width: 0 on n-button__content fixes the issue

more about why/how min-width: 0 works: https://stackoverflow.com/a/36247448/6291804

Expected API (期望的 API)

no api
@github-actions github-actions bot added the feature request New feature or request label Jun 25, 2022
@wc-matteo
Copy link
Author

a prop to style n-button__content would be useful anyway

jizai1125 added a commit to jizai1125/naive-ui that referenced this issue Jun 26, 2022
@jizai1125
fix(buttom): fix content placeholder incorrect, closes tusen-ai#3178
b6e8205
jizai1125 added a commit to jizai1125/naive-ui that referenced this issue Jun 26, 2022
@jizai1125
fix(buttom): fix content placeholder incorrect when displayed as block,
e7d380b 
closes tusen-ai#3178
jizai1125 added a commit to jizai1125/naive-ui that referenced this issue Jun 26, 2022
@jizai1125
fix(buttom): fix content placeholder incorrect when displayed as block,
c6b4eaa 
closes tusen-ai#3178
@XieZongChen XieZongChen mentioned this issue Jun 26, 2022
Merged
07akioni added a commit that referenced this issue Jun 26, 2022
@jizai1125 @07akioni
fix(buttom): doesn't omit content if content is wrapped in ellipsis c…
6d0ada7 
…ontainer, closes #3178

Co-authored-by: 07akioni <07akioni2@gmail.com>
@wc-davide wc-davide mentioned this issue Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@wc-matteo