Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared-phrase collision #1

Closed
fgardt opened this issue Aug 16, 2022 · 2 comments
Closed

shared-phrase collision #1

fgardt opened this issue Aug 16, 2022 · 2 comments

Comments

@fgardt
Copy link

fgardt commented Aug 16, 2022

Since the shared-phrase is user chosen it is possible that more than 1 send and receive party use the same phrase at the same time on the same helper server.

Right now this could cause either

  1. mixup of receiver B receiving data from sender A and vice versa

  2. both senders to "connect" to each other and sending data at each other while the receivers get no data at all

The solution would be to let the helper server generate a phrase that is not in use at the moment and send it back to the sender. The sender then can forward the phrase to the receiver and everything else then works like usual.

This reminds me a lot of croc.

@TudbuT TudbuT self-assigned this Aug 16, 2022
@TudbuT
Copy link
Owner

TudbuT commented Aug 16, 2022

I'll see what I can do. I would really like to keep it in such a way that order of connection of sender and receiver is irrelevant, but I don't think that is possible. This won't be top priority until some more sending and receiving issues are fixed, but once those are done, I'll fix this one.

About croc: QFT is peer-to-peer, croc uses a relay.

@TudbuT TudbuT added bug Something isn't working enhancement New feature or request usability-issue potential-bug and removed bug Something isn't working enhancement New feature or request labels Aug 17, 2022
@TudbuT
Copy link
Owner

TudbuT commented Oct 2, 2022

Won't fix, i dont want to use random phrases as those generally suck, maybe i will find a nice solution soon, but for now, i don't think i have a solution here.

@TudbuT TudbuT closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants