Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review for version v39 on e.g.o #318

Closed
Tudmotu opened this issue Nov 14, 2021 · 2 comments
Closed

Review for version v39 on e.g.o #318

Tudmotu opened this issue Nov 14, 2021 · 2 comments

Comments

@Tudmotu
Copy link
Owner

Tudmotu commented Nov 14, 2021

From @justperfection :

  1. Please remove all .po and .pot files:
    https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files

  2. Lang is a deprecated module. Please remove it for the next version:
    https://gjs.guide/extensions/review-guidelines/review-guidelines.html#general-advice
    Learn how to remove Lang from your code:
    https://gjs.guide/guides/gjs/legacy-class-syntax.html

If you need any help with your extension you can ask us on:
GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org
IRC Bridge: irc://irc.gimpnet.org/shell-extensions

@jrahmatzadeh
Copy link
Contributor

For number 1, I recommend to use gnome-extension pack command for creating packages. It has some benefits:

  • You won't have locale or schema files in your source.
  • You don't need to compile schema and .po files manually.

The package gnome-extension command is generating can be uploaded to the ego.
You can also install that package file with gnome-extensions install --force file.zip during developing process.

You can use my script as an example.

Also add these to gitignore to avoid uploading temp and zip files to repo:

*~
*.zip

@Tudmotu
Copy link
Owner Author

Tudmotu commented Nov 14, 2021

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants