Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Structure. #1

Merged
merged 5 commits into from Feb 16, 2022
Merged

List Structure. #1

merged 5 commits into from Feb 16, 2022

Conversation

Tufahel
Copy link
Owner

@Tufahel Tufahel commented Feb 16, 2022

In this pull request I have followed the following requirements:

  • Set up a new project with webpack.
  • Create an index.html file and write my HTML markup there. Create an empty To Do List placeholder ( div or ul element).
  • The index.html file is set as a template using the HTML Webpack Plugin.
  • Create an index.js file and set an array of some simple to-do tasks (array of objects). Each task object have contain three keys:
    a. description [string].
    b. completed [bool].
    c. index: [number].
  • Write a function to iterate over the tasks array and populate an HTML list item element for each task.
  • On page load render the dynamically created list of tasks in the dedicated placeholder. The list appears in order of the index values for each task.
  • Create a style.css and set rules for the To-Do List. CSS loaded by Webpack Style/CSS Loader.
  • All my source files (index.html, index.js, and style.css) are located in the /src directory, and my distribution files will be generated by webpack and served by webpack dev server from the /dist folder.

Here is a demo screenshot:
Screenshot from 2022-02-16 22-44-42

@github-pages github-pages bot temporarily deployed to github-pages February 16, 2022 16:46 Inactive
Copy link

@medaminedev66 medaminedev66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tufahel , 👋

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To Highlight

  • ✔️You have a descriptive PR

Required Changes ♻️

  • In the configuration of the webpack (webpack.config.js):
  • The 'mode' option has not been set. Set 'mode' option to 'development' or 'production' to enable defaults for each environment.
    You can also set it to 'none' to disable any default behavior. Learn more: https://webpack.js.org/configuration/mode/
    ``
  • I would recommend adding mode: 'development', to module.export in the webpack.config.js file.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@github-pages github-pages bot temporarily deployed to github-pages February 16, 2022 16:57 Inactive
@omar-labana
Copy link

Approved ✔️

Hi @Tufahel

Congratulations on completing this project! 👏🏼 🎉

You have correctly implemented all of the requirements📃 correctly and without any errors⚠️ or bugs🪲.

Cheers and good luck in your next milestones! 🍀

Feel free to leave any questions or comments in the PR thread(don't forget to tag me 😄) if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Tufahel Tufahel merged commit fdfa67d into main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants