Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare output to expected output #35

Closed
Tracked by #97
abelsiqueira opened this issue Aug 16, 2023 · 3 comments
Closed
Tracked by #97

Compare output to expected output #35

abelsiqueira opened this issue Aug 16, 2023 · 3 comments
Labels
Type: addition Add something that doesn't exist Zone: testing Related to improving or fixing the tests

Comments

@abelsiqueira
Copy link
Member

abelsiqueira commented Aug 16, 2023

Compare output to expected output, i.e., test that the output of the solver is correct.

@abelsiqueira abelsiqueira added Type: improvement Better way of doing something Zone: testing Related to improving or fixing the tests labels Aug 16, 2023
@clizbe
Copy link
Member

clizbe commented Sep 19, 2023

I think this can be done with just a dataframe comparison of:
D1==D2
And checking the output.

@clizbe clizbe modified the milestone: Output Sep 20, 2023
@clizbe clizbe mentioned this issue Sep 20, 2023
11 tasks
@clizbe clizbe added Type: addition Add something that doesn't exist and removed Type: improvement Better way of doing something labels Sep 21, 2023
@clizbe clizbe self-assigned this Sep 29, 2023
@clizbe clizbe removed their assignment Oct 4, 2023
@clizbe
Copy link
Member

clizbe commented Jan 4, 2024

@datejada Is this necessary if we're already comparing the obj function value?

@datejada
Copy link
Member

datejada commented Jan 4, 2024

@clizbe I agree; the current test with the different test cases (Tiny, Tiny with variable resolution, and Norse) are more than enough. We can close this issue.

@datejada datejada closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: addition Add something that doesn't exist Zone: testing Related to improving or fixing the tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants