Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New parameter to use tighter storage formulation #641

Conversation

datejada
Copy link
Member

@datejada datejada commented May 11, 2024

Pull request details

Describe the changes made in this pull request

New parameter use_binary_storage_method in the inputs files and schema of the model

List of related issues or pull requests

Closes #638

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • [NA] The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (40e326c) to head (4a81659).

❗ Current head 4a81659 differs from pull request most recent head ff1f748. Consider uploading reports for the commit ff1f748 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #641   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          671       671           
=========================================
  Hits           671       671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made a suggestion to use Union{Missing,Symbol}. This means using missing instead of none.

src/input-schemas.jl Outdated Show resolved Hide resolved
Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abelsiqueira abelsiqueira merged commit c06760e into TulipaEnergy:main May 13, 2024
5 checks passed
@datejada datejada deleted the 638-new-parameter-use-tighter-storage-method branch May 13, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the new parameter and update the input files for the use of a tighter formulation for storage assets
2 participants