Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #651

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Fix bug #651

merged 1 commit into from
Jun 12, 2024

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Jun 11, 2024

Pull request details

Describe the changes made in this pull request

Fix bug storage method

List of related issues or pull requests

Closes #650

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

@gnawin gnawin requested a review from datejada June 11, 2024 10:29
@gnawin
Copy link
Member Author

gnawin commented Jun 11, 2024

Welcome back @datejada as a gift, here's a PR waiting for your review 😄 (it is related to the epic issue we worked on together so good to have you four-eye check).

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e3d52d4). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #651   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        15           
  Lines           ?       744           
  Branches        ?         0           
========================================
  Hits            ?       744           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Nice catch @gnawin Thanks for the fix

@datejada datejada merged commit 85817cc into TulipaEnergy:main Jun 12, 2024
7 checks passed
@gnawin gnawin deleted the 650-bug-storage-method-energy branch June 12, 2024 08:23
@gnawin gnawin restored the 650-bug-storage-method-energy branch June 12, 2024 08:23
@gnawin gnawin deleted the 650-bug-storage-method-energy branch June 12, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Model errors when a storage asset is investable==false but storage_method_energy==true
2 participants