Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join profiles files into a single file per period type #672

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Jun 26, 2024

Pull request details

Describe the changes made in this pull request

Join the profiles-rep-periods-* into one a similar for timeframe profiles.
It's mostly a file change.

List of related issues or pull requests

Closes #668

Collaboration confirmation

As a contributor I confirm

  • I read and followed the instructions in README.dev.md
  • The documentation is up to date with the changes introduced in this Pull Request (or NA)
  • Tests are passing
  • Lint is passing

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5aee7e5) to head (1ab07e2).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #672   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          788       784    -4     
=========================================
- Hits           788       784    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira
Copy link
Member Author

I have to confess that I spent most of the development time of this with a bug that I created myself where I forgot to convert the - to _ in the profile_type. 😢

@abelsiqueira abelsiqueira marked this pull request as ready for review June 26, 2024 15:40
Copy link
Member

@datejada datejada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks more clean and straightforward. Thanks!

@datejada datejada merged commit 1c63605 into TulipaEnergy:main Jun 26, 2024
7 checks passed
@abelsiqueira abelsiqueira deleted the 668-merge-profiles branch June 26, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge all profiles-* files into one
2 participants