Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide toolbar button captions #237

Closed
thomas694 opened this issue Apr 23, 2022 · 4 comments
Closed

Option to hide toolbar button captions #237

thomas694 opened this issue Apr 23, 2022 · 4 comments
Assignees
Labels
beginner Estimated level of difficulty enhancement New feature or request first-timers-only an easy issue for first time contributors only good first issue Good for newcomers

Comments

@thomas694
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As an user who uses TumblThree in another language than english, it's sometimes disturbing that the toolbar button widths are very different due to longer translations in other languages.

Describe the solution you'd like
There should be an option in the settings to hide the toolbar button captions. If this setting is enabled, only the icons would be shown on the buttons and thus the buttons are all equal width.
Maybe instead of showing no help at all, the caption texts can be shown as a tooltip.

Describe alternatives you've considered
To leave it as it is.

Additional context
new_issue_1
new_issue_2

@thomas694
Copy link
Contributor Author

As before this one is for first-timers-only. That means that we will only accept a PR for this one from someone who's never contributed to open source before. This one is particularly easy (but don't make that statement make you feel bad if you have a hard time with it, there's more to contributing to open source than changing lines of code, especially if it's your first time). We walk you through it if you need help. :-) Here are the steps to get a PR merged (see also our guide).

There should be an option in the settings to hide the toolbar buttons' caption. If this setting is enabled, only the icons are shown on the buttons and thus the buttons are all equal width.
Additionally, if the option is enabled, a tooltip shall be shown on the buttons. The button captions can be used as texts for the tooltips.

  • Create a fork of the repository
  • Clone it to your local disk and create a new branch (e.g. 000-hide-toolbar-button-captions)
  • Look which class and view is dealing with the toolbar buttons. How can a tooltip be shown on the buttons? What needs to be changed?
  • Add your solution
  • Build the app and run it
  • Check the toolbar in the default/english language. Does it work as expected? Is a tooltip shown for all the buttons on hovering?
  • Switch the languages in the settings, restart the app and check again.
  • Commit your changes mentioning "issue #000" somewhere in your commit message title or description
  • Push your changes to your fork, create a PR, get merged, celebrate??

We are happy to support you if you need help.

@thomas694 thomas694 added enhancement New feature or request good first issue Good for newcomers beginner Estimated level of difficulty first-timers-only an easy issue for first time contributors only labels May 21, 2022
@Mannuel25 Mannuel25 converted this issue into a discussion Aug 27, 2022
@thomas694 thomas694 reopened this Aug 30, 2022
@rexius41
Copy link
Collaborator

rexius41 commented Oct 2, 2023

Hi could I take on this issue if possible

@thomas694
Copy link
Contributor Author

Hello,
thanks for your interest. Yes, you can work on that issue.
If you have a question or get stuck, feel free to ask.

@thomas694
Copy link
Contributor Author

Thank you for your first contribution and PR to our TumblThree project.
Your PR has been merged and you've been added to our list of contributors.
We would be happy to receive more contributions from you in the future. Maybe you can help us with one or the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Estimated level of difficulty enhancement New feature or request first-timers-only an easy issue for first time contributors only good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants