Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler generated aliases #533

Closed
trappmartin opened this issue Sep 14, 2018 · 4 comments
Closed

Compiler generated aliases #533

trappmartin opened this issue Sep 14, 2018 · 4 comments

Comments

@trappmartin
Copy link
Member

Check which of the generated alias functions are necessary.

@mohamed82008
Copy link
Member

May you elaborate?

@trappmartin
Copy link
Member Author

The compiler currently generates alias functions for the closure function (model function). We should check after merging #513 which of those alias functions are actually required.

@mohamed82008
Copy link
Member

mohamed82008 commented Dec 15, 2018

Is this still an issue? It seems that the current closure definitions handle the cases of:

  1. No input - for convenient sampling from prior.
  2. vi input with no sampler which is convenient for MAP optimization as in Maximum a posterior for Turing models #605.
  3. sampler and vi inputs which is used inside of Turing a lot.

Perhaps the only case I am not sure where it is used is when only sampler is input.

@yebai yebai mentioned this issue Feb 19, 2019
56 tasks
@mohamed82008
Copy link
Member

The aliases were removed from the compiler in #965. Different methods were defined for (model::Model)(...) instead but all seem to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants