Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named function kernels for sliding windows #86

Merged
merged 5 commits into from Nov 2, 2021

Conversation

lmcinnes
Copy link
Contributor

For now just a couple of simple test kernels; one for count time series anomaly detection, and another to work with time interval time series anomaly detection, which is similar. Enough basics to test out that the named function code-path works.

@codecov-commenter
Copy link

Codecov Report

Merging #86 (78e002c) into master (e7048c0) will decrease coverage by 0.20%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   91.29%   91.09%   -0.21%     
==========================================
  Files          24       24              
  Lines        3861     3975     +114     
==========================================
+ Hits         3525     3621      +96     
- Misses        336      354      +18     
Impacted Files Coverage Δ
vectorizers/_window_kernels.py 83.94% <73.80%> (-4.61%) ⬇️
vectorizers/transformers/sliding_windows.py 93.00% <88.60%> (-3.59%) ⬇️
vectorizers/tests/test_transformers.py 100.00% <100.00%> (ø)
vectorizers/transformers/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b68a62...78e002c. Read the comment docs.

Copy link
Collaborator

@jc-healy jc-healy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look solid.

@jc-healy jc-healy merged commit a3116c8 into TutteInstitute:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants