Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Binary Option? #45

Open
acwooding opened this issue Jun 20, 2020 · 1 comment
Open

Possible Binary Option? #45

acwooding opened this issue Jun 20, 2020 · 1 comment

Comments

@acwooding
Copy link
Contributor

Wondering your thoughts on something like the Sklearn CountVectorizer option of binary=True for easy use in cases when counts don't matter...I know it's easy to do after the fact, but it could be a nice option to have where it makes sense (like NgramVectorizer). (Maybe it already exists, but I didn't see it). It would make it free to use as part of DocVectorizer as well. Otherwise I think you have to break the whole pipeline apart and "do it by hand" just to binarize a matrix.

@jc-healy
Copy link
Collaborator

Hi Amy, I think that makes good sense. It would probably be easiest to code (though not most efficient) by just setting all the non-zero values to 1 at the end of the function when that option is selected. We'll happily accept a PR doing something like that if you are keen. Otherwise I'll push it onto my to do stack (warning it will be fairly low and I'm not working on this project over the summer so I'm thinking September for me).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants