Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSV_XS.pm #46

Merged
merged 4 commits into from
Aug 7, 2023
Merged

Update CSV_XS.pm #46

merged 4 commits into from
Aug 7, 2023

Conversation

x12340
Copy link
Contributor

@x12340 x12340 commented Jul 2, 2023

No description provided.

@x12340
Copy link
Contributor Author

x12340 commented Aug 4, 2023

Do you accept the change?

@Tux
Copy link
Owner

Tux commented Aug 5, 2023

The typo is indeed a typo. Thanks for spotting. IMHO "whitespace" is more common than "whitespaces"

$ diff --help | grep white
  -Z, --ignore-trailing-space     ignore white space at line end
  -b, --ignore-space-change       ignore changes in the amount of white space
  -w, --ignore-all-space          ignore all white space

I have no native english tongue, so maybe I should just folow that and consistently use white space (with a space singular)

If you do that, I'll accept

@x12340
Copy link
Contributor Author

x12340 commented Aug 5, 2023

Basically I mean that in the script was used "whistespace", which I think is a typo:

" -w --ignore-all-space ignore all whistespace is all fields\n"

Regards!

@Tux
Copy link
Owner

Tux commented Aug 5, 2023

Yes, and I already approved that part :)
I thought you might want to make it a new all "white space" PR

@Tux Tux merged commit 9b19a30 into Tux:master Aug 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants