Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending the wrong configuration file #13

Open
FAMILIAR-project opened this issue Jul 4, 2019 · 3 comments
Open

Sending the wrong configuration file #13

FAMILIAR-project opened this issue Jul 4, 2019 · 3 comments
Assignees

Comments

@FAMILIAR-project
Copy link
Collaborator

It's perhaps one of the most critical bug ever noticed for this project.
I think it impacts results of 4.15, but it can be the case for 4.13.3 as well (for recent compilations)

In the last entries of the database I've observed that
CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y is set instead of CONFIG_CC_OPTIMIZE_FOR_SIZE=y.
I don't know why!

Basically, I have impression we are sending the wrong configuration file due to computation of several kernel sizes.
The code here is suspicious:
https://github.com/TuxML/ProjetIrma/blob/dev/compilation/compiler.py#L320-L331

and something is forcing the value of CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y
(see also TuxML/ProjetIrma#169 and the possible options impacted)

@mipicard
Copy link
Contributor

mipicard commented Jul 5, 2019

This piece of code is basically rewriting the whole .config file with the original content that we read earlier. To be sure that is from here that the bug come, i suggest that instead of reading the content, we can copy the .config file in other place, do our stuff and copying it back. If the bug remains, it should not come from here.

@FAMILIAR-project
Copy link
Collaborator Author

The make just after the restore of original_config is strange no? Does it recompile?

@mipicard
Copy link
Contributor

mipicard commented Jul 5, 2019

It should restore the compiled kernel to its earlier states, since it have been changed to use a compression. So yes, it recompile, but just in the later stage, where the option for compression algorithm kick in.

@FAMILIAR-project FAMILIAR-project self-assigned this Jul 1, 2020
@FAMILIAR-project FAMILIAR-project transferred this issue from TuxML/ProjetIrma Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants