Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing of stock parts cause attachment issues #6

Open
Jammer-TD opened this issue Apr 19, 2021 · 6 comments
Open

Resizing of stock parts cause attachment issues #6

Jammer-TD opened this issue Apr 19, 2021 · 6 comments

Comments

@Jammer-TD
Copy link

I was able to create this issue and Identify that the problem goes way, when RESTOCK PARTS Mod By @Netea is removed.
[1.11.1] Restock - Revamping KSP's art (KSP 1.11, Jan 31)..
I didn't think this was the exact same as others reported with attachment, merge to any outstanding Item if needed.
Attached logs"
ts2446-1.11.2-01.zip
Here is normal:
NP-no_restock-ts245
Here not so much:
Sym-Prob-restock-ts245
The item is a single panel with a sym connected duplicate to each side then resized!
just thought I would let you know I am not sure whom could resolve this as, without RECALL PARTS the problem goes away so maybe it on them.
thanks
Jammer

@Lisias
Copy link
Contributor

Lisias commented Apr 19, 2021

We have a bug on Symmetry on KSP itself, and TweakScale not being able to handle perfectly all the symetries use case does not helps neither.

I will investigate. ReStock may be using some hidden feature on KSP that I'm missing.

@Jammer-TD
Copy link
Author

Jammer-TD commented Apr 25, 2021

So Just for assistance of Identifying this better for you. I tried various combination's, reverting both restock and TS. this error only develops after ts2.4.4.2(which works fine)! v2.4.4.3 complains about ksp version, and the issue appears, v2.4.4.4 has no "houston's" but the issue is present, and same for v 2.4.4.5.
I just thought this may help to know.
Jammer-TD
ts2443-1.11.2-01.zip

@Lisias
Copy link
Contributor

Lisias commented Oct 12, 2021

I'm moving this to be tackled down sooner, as I think this just bitten me while doing some tests for another Fellow Kerbonaut.

Lisias referenced this issue in TweakScale/TweakScale Oct 24, 2021
@Lisias
Copy link
Contributor

Lisias commented Oct 24, 2021

Note to myself: I had my ass bashed mercilessly on DistantObject on a similar problem with ReStock.

Long history made short: ReStock 1.4.2 (at least) is replacing some Stock Modules with their own versions, and I need to inspect and learn about these new PartModules in order to have this sorted out for both TweakScale and DistantObject.

So this is not a bug anymore, but an enhancement - and I will post pone it to a Milestone dedicated only to enhancements.

Lisias referenced this issue in TweakScale/TweakScale Oct 24, 2021
@Lisias
Copy link
Contributor

Lisias commented Nov 30, 2021

Craft file: craft.zip

Evidence of the thing working:
screenshot46
screenshot47

TODO: use this craft to check the behaviour on KSP 1.12.2 with and without ReStock

@Lisias
Copy link
Contributor

Lisias commented Nov 30, 2021

This is confirmed to be something related to ReStock.

Moving the issue to the TSCo-PKMC where it will be tackled own.

@Lisias Lisias transferred this issue from TweakScale/TweakScale Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants