Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ill-looking pos from dequePos #12

Closed
TwinFan opened this issue Oct 23, 2018 · 1 comment
Closed

Remove ill-looking pos from dequePos #12

TwinFan opened this issue Oct 23, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@TwinFan
Copy link
Owner

TwinFan commented Oct 23, 2018

Current Situation
Aircraft seem to move back and forth, turn left/right.
Especially when different channels are combined.
Also see bug #11 .

Suggested Solution
We might need a logic to just remove an ill-looking pos from dequePos, like:

  • Heading turns more than 90° but with next pos we would fly straight (<30°)
  • VSI would switch between down/up, but with next pos we would keep or level

Alternative
Don't allow mixing channels for any one aircraft...but how would we decide that we need to switch channels when coverage of current channel fades and another one seems better? How would we define 'better'?

Benefit
More realistic looking landings.

Additional context
Look at this example: there is a position, which goes backward, and then we suddenly accelerate to 450+ knots:

22:53.054 LiveTraffic DEBUG LTFlightData.cpp:667/AddNewPos: DEBUG POS DATA: a/c A7C849 SimTime: 1534968806.1 - 2018-08-22 20:13:26
a/c A7C849 ppos: ( 40.790, -73.867) 54f GND_OFF {211°, 7↕︎, 0↔︎} [1534968806.1] Y: -0f Phase: 61 Final
posList:
( 40.790, -73.867) 91f GND_OFF {211°, 2↕︎, 0↔︎} [1534968795.0] <211°, 0m @ 0kt, -202ft/m>
( 40.790, -73.867) -0f GND_ON {212°, 7↕︎, 0↔︎} [1534968822.0]
posDeque:
( 40.788, -73.869) -0f GND_ON {211°, 2↕︎, 0↔︎} [1534968799.7] < 31°, 323m @ 28kt, -0ft/m>
( 40.790, -73.867) -0f GND_ON {212°, 0↕︎, 0↔︎} [1534968822.0] <212°, 1846m @ 461kt, 51ft/m>
( 40.776, -73.878) 7f GND_ON {206°, 0↕︎, 0↔︎} [1534968829.8] <204°, 340m @ 19kt, 0ft/m>
( 40.773, -73.880) 7f GND_ON {204°, 0↕︎, 0↔︎} [1534968865.4]

@TwinFan TwinFan added the enhancement New feature or request label Oct 23, 2018
@TwinFan
Copy link
Owner Author

TwinFan commented Jan 19, 2019

Solved with #57.

@TwinFan TwinFan closed this as completed Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant