Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade item issue. #193

Closed
Anastaciaa opened this issue Apr 29, 2018 · 3 comments
Closed

Trade item issue. #193

Anastaciaa opened this issue Apr 29, 2018 · 3 comments
Labels
Projects
Milestone

Comments

@Anastaciaa
Copy link

Anastaciaa commented Apr 29, 2018

If player1 trade stackable item with player2 like crystal coins and player1 put for example 44 cc on arrow slot and trade another item for example sword with trade partner player2 who giving you on 100 cc on trade for the sword then if you both accept trade, 44cc on arrow slot in player1 will fill to 100cc and rest(44cc) will stay in trade partner bp player2 what is bug because all 100cc money should be moved to player 1.

I know which function fails but i dont know what exactly causing this in this function.
This is the function. Something is wrong with autostack i suppose.

https://github.com/TwistedScorpio/OTHire/blob/322095b12dbbfe6644dff6a615f43d7dcd27e2ab/source/player.cpp#L3088

I solved this by replacing whole function from avesta.

@peonso peonso added this to the Version 1.0 milestone Apr 30, 2018
@peonso peonso added the bug label Apr 30, 2018
@peonso
Copy link
Collaborator

peonso commented May 3, 2018

Won't it break autostack?

@peonso
Copy link
Collaborator

peonso commented May 3, 2018

@peonso peonso added this to To Do in OTHire 1.0 May 4, 2018
@Anastaciaa
Copy link
Author

It will break autostack i guess.

@peonso peonso closed this as completed in 76717e7 May 6, 2018
@peonso peonso moved this from To Do to Done in OTHire 1.0 May 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants