This repository has been archived by the owner on May 1, 2020. It is now read-only.
This fixes multi line if formatting for those of us who don't like writing if.. then :) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgejecook
force-pushed
the
fixes_indentaion_for_multiline_if_with_no_then
branch
from
eb2d3ae
to
9f41530
Compare
|
@georgejecook this PR is still failing the travisci build. You mentioned in # 15 that you got it working, but I don't see any of the changed code in this PR. |
|
I’ve no idea what’s going on with this - I don’t have this branch anymore..
https://github.com/georgejecook/vscode-brightscript-language
locally or remotely..!?
All I added was getting rid of the skip on the if without then test - which
made it pass coverage.
On November 19, 2018 at 4:31:09 PM, Bronley Plumb (notifications@github.com) wrote:
@georgejecook <https://github.com/georgejecook> this PR is still failing
the travisci build. You mentioned in # 15
<#15 (comment)>
that you got it working, but I don't see any of the changed code in this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKIUQ0uvo3gp8_qKBd7qGXGf6tNxp5jks5uwyMcgaJpZM4Ynxtm>
.
|
…This fixes multi line if formatting for those of us who don't like writing if.. then :)
georgejecook
force-pushed
the
fixes_indentaion_for_multiline_if_with_no_then
branch
from
9f41530
to
cfb74b8
Compare
|
Okay - I’m a numpty. I was on the wrong repo :)
I’ve pushed up the amended commit with the relevant fix.
On November 19, 2018 at 4:52:51 PM, George Cook (george@tantawowa.com)
wrote:
I’ve no idea what’s going on with this - I don’t have this branch anymore..
https://github.com/georgejecook/vscode-brightscript-language
locally or remotely..!?
All I added was getting rid of the skip on the if without then test - which
made it pass coverage.
On November 19, 2018 at 4:31:09 PM, Bronley Plumb (notifications@github.com) wrote:
@georgejecook <https://github.com/georgejecook> this PR is still failing
the travisci build. You mentioned in # 15
<#15 (comment)>
that you got it working, but I don't see any of the changed code in this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKIUQ0uvo3gp8_qKBd7qGXGf6tNxp5jks5uwyMcgaJpZM4Ynxtm>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assumes a line is multi-line-if, when finding if token with no then.