Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: avoid awkward language #186

Merged
merged 1 commit into from Jul 22, 2017
Merged

readme: avoid awkward language #186

merged 1 commit into from Jul 22, 2017

Conversation

tshepang
Copy link
Contributor

Also, make Vec parameter visible when rendered

dtolnay
dtolnay suggested changes Jul 22, 2017
View reviewed changes
Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decode from &[u8], not from Vec<u8>. Could you suggest a change that would communicate this more clearly?

@tshepang
Copy link
Contributor Author

fixed

dtolnay
dtolnay approved these changes Jul 22, 2017
View reviewed changes
Copy link
Contributor

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dtolnay dtolnay merged commit 8c7aaba into bincode-org:master Jul 22, 2017
@tshepang tshepang deleted the foo branch July 22, 2017 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tshepang @dtolnay