Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goja as additional JSVM driver #1893

Closed
joshblakeley opened this issue Aug 31, 2018 · 4 comments
Closed

Add goja as additional JSVM driver #1893

joshblakeley opened this issue Aug 31, 2018 · 4 comments

Comments

@joshblakeley
Copy link
Member

Do you want to request a feature or report a bug?

Feature

What is the current behavior?
Currently we use Otto driver for our JSVM
We have option of using https://github.com/dop251/goja which claims a 6/7 times performance increase and a higher level of conformance to ECMAScript standards than Otto has.

It is clearly related to Otto and has a similar (but not identical) API.

I'd like us to give users the option of which JSVM is used when running virtual endpoints or javascript middleware, and this is a good candidate for our JSVM V2.

It can be chosen via a jsvm_engine option in config, where default value is "otto". Also JSVM plugins can also be loaded via bundles, and in manifest you specify "driver". It should accept goja value too.

@letzya
Copy link
Contributor

letzya commented Sep 20, 2019

+1 from another client

@stale
Copy link

stale bot commented Mar 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, please add comments to this ticket if you would like it to stay open. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 25, 2020
@l3ender
Copy link
Contributor

l3ender commented Mar 25, 2020

Please keep open. We are using JSVM and would always welcome performance enhancements for it.

@stale stale bot removed the wontfix label Mar 25, 2020
@andyo-tyk
Copy link
Contributor

In our investigations into goja we identified no noticeable performance increase for the types of tasks that Tyk uses; for this reason we stopped any development towards switching the JSVM driver.

We are always on the look out for opportunities to improve the performance of Tyk, but this particular avenue is currently closed.

I will close this ticket to reduce noise, but the interest in performance enhancements in this area is noted for future product evolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants