Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink toolbar button is not working on Safari. #530

Closed
hsingh-ds opened this issue Jan 18, 2024 · 8 comments · Fixed by #609
Closed

Hyperlink toolbar button is not working on Safari. #530

hsingh-ds opened this issue Jan 18, 2024 · 8 comments · Fixed by #609
Assignees
Labels
bug Something isn't working prio:mid Medium priority

Comments

@hsingh-ds
Copy link

Describe the bug
I am trying to create a hyperlink on safari browser but the button is not working.

To Reproduce
Open editor app in Safari browser and try to add hyperlink.

@hsingh-ds hsingh-ds added the bug Something isn't working label Jan 18, 2024
@matthewlipski matthewlipski added the prio:mid Medium priority label Jan 18, 2024
@v-porytskyi
Copy link

v-porytskyi commented Jan 19, 2024

And I see the same behavior. But the paragraph and colors buttons are also not working in my case.
Safari Version 17.1 (19616.2.9.11.7)

@eatmoarrice
Copy link

0.10.1 works btw. It breaks on 0.11.0.

@eatmoarrice
Copy link

This seems to be fixed in 0.11.1.

@artwist-polyakov
Copy link

Hello, can you tell me why you are closing this Issue? After all, the bug persists in safari until now.

@YousefED
Copy link
Collaborator

YousefED commented Feb 13, 2024

Hello, can you tell me why you are closing this Issue? After all, the bug persists in safari until now.

Hi @artwist-polyakov ! Can you confirm you're still having this issue on the latest version? (@eatmoarrice reported it was fixed).

On a side note, we can always prioritize issues for sponsors and / or take contributions, these largely drive our roadmap / prioritization

@artwist-polyakov
Copy link

Hi @artwist-polyakov ! Can you confirm you're still having this issue on the latest version? (@eatmoarrice reported it was fixed).

Hello,

Yes, I can confirm that I am still experiencing the issue with hyperlinks not working in Safari even after checking the latest version available at BlockNote.js. If there has been a more recent update that is not reflected on the website, could you please point me to where I can access it? Otherwise, it seems the problem persists in the version currently provided on the official site.

@eatmoarrice
Copy link

Sorry it is indeed not working. There are several conditions where it works, and my testing happened to be under one such:

  • When you interact with the menu that appears after rearranging the blocks.
  • When you interact with the menu that appears after a long press on the hyperlink button (the menu will disappear for a sec, then re-appear).
    hyperlink

@artwist-polyakov
Copy link

Could we reopen this issue (as not fixed)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:mid Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants