Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with getLanguageId on latest version #303

Closed
rw-access opened this issue Nov 12, 2021 · 2 comments
Closed

Error with getLanguageId on latest version #303

rw-access opened this issue Nov 12, 2021 · 2 comments

Comments

@rw-access
Copy link
Contributor

rw-access commented Nov 12, 2021

Hey @CGNonofr, it looks like the latest changes from #301 are breaking for me.

Relevant installed versions:

@codingame/monaco-jsonrpc: 0.3.1
@codingame/monaco-languageclient: 0.17.0
monaco-editor: 0.30.1
@monaco-editor/react: 4.3.1
@monaco-editor/loader: 1.2.0

Here's a stack trace, appears the problem is in onDidChangeTextDocument

helpers.ts:111 Uncaught TypeError: model.getLanguageId is not a function
    at MonacoWorkspace.setModel (monaco-workspace.ts:71)
    at MonacoWorkspace.addModel (monaco-workspace.ts:48)
    at new MonacoWorkspace (monaco-workspace.ts:23)
    at create (monaco-services.ts:30)
    at Object.install (monaco-services.ts:35)
    ...
@rw-access
Copy link
Contributor Author

rw-access commented Nov 12, 2021

Oh, looks like there's a 0.28 cached Monaco somewhere in `@monaco-editor/loader...

editor@0.28.1/min/vs/editor/editor.main.js:60:13525)
    at https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:573:12639
    at Array.map (<anonymous>)
    at https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:573:12628
    at Generator.next (<anonymous>)
    at https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:60:13728
    at new Promise (<anonymous>)
    at ke (https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:60:13525)
    at s (https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:573:12526)
    at https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:639:1471
    at S (https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:60:14204)
    at r.runner (https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:639:1445)
    at r.doRun (https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:60:17977)
    at r.onTimeout (https://cdn.jsdelivr.net/npm/monaco-editor@0.28.1/min/vs/editor/editor.main.js:60:17943)
    ...

@rw-access
Copy link
Contributor Author

rw-access commented Nov 12, 2021

Problem solved: my dependency @monaco-editor/loader was pinned to load 0.28.1
https://github.com/suren-atoyan/monaco-loader/blob/master/src/config/index.js#L3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant