textDocument/didChange Did not follow the LSP protocol

[vincentLiuxiang]

hi all, I just want to try lsp in monaco, and I was very excited to find this project.
However, When I tried to analyze the websocket data package, I found a bug.

then, I tried to analyze theia-ide, It works fine.

what should I do to solve this problem?

[akosyakov]

Hi @vincentLiuxiang, could you be more specific what does not follow the LSP?

[vincentLiuxiang]

@akosyakov
You can look at the red square inside the pictures.
textDocument/didChange

In LSP, when the method is textDocument/didChange, the params must be DidChangeTextDocumentParams

interface DidChangeTextDocumentParams {
	/**
	 * The document that did change. The version number points
	 * to the version after all provided content changes have
	 * been applied.
	 */
	textDocument: VersionedTextDocumentIdentifier;

	/**
	 * The actual content changes. The content changes describe single state changes
	 * to the document. So if there are two content changes c1 and c2 for a document 
	 * in state S10 then c1 move the document to S11 and c2 to S12.
	 */
	contentChanges: TextDocumentContentChangeEvent[];
}

/**
 * An event describing a change to a text document. If range and rangeLength are omitted
 * the new text is considered to be the full content of the document.
 */
interface TextDocumentContentChangeEvent {
	/**
	 * The range of the document that changed.
	 */
	range?: Range;

	/**
	 * The length of the range that got replaced.
	 */
	rangeLength?: number;

	/**
	 * The new text of the range/document.
	 */
	text: string;
}

but monaco-languageclient send data to sever like this:

{
    "method": "textDocument/didChange",
    "params": {
         "contentChanges": [
                 {  "text": "{↵    "$schema": "http://json.schemastore.org/coffeelint",↵    "line_endings": "unix"↵}aaa"  }
         ]
     }
}

the difference is in contentChanges.

[akosyakov]

It depends on a language server, the json server used in the example is not able to handle incremental changes, so the client always sends the whole document. A server can communicate it as a part of exchanging initialization capabilities. Look for TextDocumentSyncKind in the specification.

[vincentLiuxiang]

monaco-languageclient

theia-ide

[vincentLiuxiang]

so, if My server support handle incremental changes, I can get the same result like the theia-ide?

what's more could you give an example that is closer to the production environment? java, js and so on?

[vincentLiuxiang]

@akosyakov I am very new in LSP, I have Look for TextDocumentSyncKind in the specification. Thank you very much!

[akosyakov]

@vincentLiuxiang You are welcome, I am closing it.

[Louis-7]

I know this issue has been closed but I saw the screen shot, there is a "Content-Length: 25x" at the beginning of the data return by web-socket which as same as my project which use the language server provide by monaco-languageclient. This "Content-Length" will cause an error at language server side. But I didn't see it in the example given by monaco-languageclient. I'm wondering why I have this "Content-Length" and will it crash the hole process?