Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve vscode/services #458

Closed
CraigMeng opened this issue Feb 6, 2023 · 4 comments
Closed

Cannot resolve vscode/services #458

CraigMeng opened this issue Feb 6, 2023 · 4 comments

Comments

@CraigMeng
Copy link

Hi,

Thank you very much for the efforts!

I want to upgrade language client follow the documentation and troubleshooting recently but got compiling error.
I tried to remove lots of codes and managed to get a minimal example here: https://github.com/CraigMeng/monaco-webpack-node-12

The error I got:

image

@CraigMeng
Copy link
Author

node version: 12.22.12

@CGNonofr
Copy link
Collaborator

CGNonofr commented Feb 6, 2023

Your issue is probably related to the usage of webpack@4 which is not able to understand subpath exports. Webpack 5 is fine with it (and was released more than 2 years ago)

Btw, note that you have another issue: vscode is duplicated in your project and it will create issues:

image

@kaisalmen We have probably a too strict dependency version here, we're missing a ~

@kaisalmen
Copy link
Collaborator

@CGNonofr yes, you are right. I just checked. The peerDependency definition is correct, but there is still a separate dependency that is strict. I will fix/remove this in the upcoming days

@CraigMeng
Copy link
Author

@CGNonofr Thank you! Yes, it is webpack 4 issue and I confirm that it works very well after upgrade to webpack5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants