Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique symbol property names are mangled #1514

Closed
thebestnom opened this issue Feb 20, 2021 · 2 comments
Closed

Unique symbol property names are mangled #1514

thebestnom opened this issue Feb 20, 2021 · 2 comments
Labels
bug Functionality does not match expectation

Comments

@thebestnom
Copy link

thebestnom commented Feb 20, 2021

Search Terms

unique symbol, mangled name

Problem

unique symbols looks weird in documentation because it get generated like a normal const

Suggested Solution

use const name instead of generated const in unique symbol

export const NEOVIS_ADVANCED_CONFIG: unique symbol;
export interface Test {
  [NEOVIS_ADVANCED_CONFIG]?: string; // this will look bad in documentation
}

image

@thebestnom thebestnom added the enhancement Improved functionality label Feb 20, 2021
@Gerrit0 Gerrit0 changed the title Special case for unqiue symbol Unique symbol property names are mangled Feb 20, 2021
@Gerrit0 Gerrit0 added bug Functionality does not match expectation reproduced and removed enhancement Improved functionality labels Feb 20, 2021
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 20, 2021

This is a tricky one... related to #1226, though this is a particularly bad case. For now, I'll patch this with [NEOVIZ_ADVANCED_CONFIG] showing up as the property name... We really need to better handle dynamic property members...

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Feb 20, 2021

Fix released in 0.20.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
2 participants