Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot bundle express.d.ts references #16

Closed
pgrm opened this issue Apr 21, 2015 · 2 comments
Closed

Cannot bundle express.d.ts references #16

pgrm opened this issue Apr 21, 2015 · 2 comments

Comments

@pgrm
Copy link
Contributor

pgrm commented Apr 21, 2015

in the current version of express.d.ts is the following code block:

/* =================== USAGE ===================
    import express = require('express');
    var app = express();
 =============================================== */

because the end of a comment is detected with the following regex: /^[ \t]*\*+\/ it means that dts-bundle never detects the end of the comment and thinks, the whole files is commented out.

@poelstra
Copy link

@pgrm Note that progress is being made on creating a solution that works out-of-the-box. See e.g. microsoft/TypeScript#2338, microsoft/TypeScript#2839. In the mean time, it may be interesting to look at https://github.com/SitePen/dts-generator, as it doesn't use regexes for creating the bundles and is more recently updated.

@pgrm
Copy link
Contributor Author

pgrm commented Apr 21, 2015

The typescript issues are, where I've found this repository in the first place, for now I've just put a new line before the end of the comment and that works, but I'll also try dts-generator, thx

@tolemac tolemac closed this as completed Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants