Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files that provide only type dependencies for main entry and unused files are not being checked for TS errors. #502

Closed
dmitrysteblyuk opened this issue Aug 23, 2020 · 2 comments
Labels

Comments

@dmitrysteblyuk
Copy link

dmitrysteblyuk commented Aug 23, 2020

Current behavior

If you import only a type (or use the imported object for type definition only) from a file it will be skipped during TS check by the plugin. So will be any unused ts files.

Expected behavior

All files included in tsconfig.json are being checked.
This is exactly same behavior ts-loader and tsc follow.

Steps to reproduce the issue

I provided simple repro below.
Just run yarn && yarn build to observe that no errors are triggered.
Change transpileOnly to false in webpack.config.js or just run npx tsc and see that both ts-loader and tsc do not ignore TS errors.

Issue reproduction repository

https://github.com/dmitrysteblyuk/fork-ts-checker-bug-repro

Environment

  • fork-ts-checker-webpack-plugin: ^5.1.0 (last known working version - 1.5.0)
  • typescript: 3.9.7
  • eslint: -
  • webpack: ^4.44.1
  • os: Mac OS X 10.15.5
@piotr-oles
Copy link
Collaborator

Duplicate: #36 . It's an old issue, I hope I will be able to solve it soon.

@dmitrysteblyuk
Copy link
Author

It's an old issue, I hope I will be able to solve it soon.

Thanks! that would be really great!

Maybe you should consider changing the title of #36. I saw this issue, but since the bug itself was not actually about triggering the rebuild, I thought it actually could be a different issue, and reported a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants