Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwriteFilesGlob does not work when src uses variables and updateFiles #303

Closed
nsgundy opened this issue Oct 31, 2015 · 2 comments
Closed

Comments

@nsgundy
Copy link

nsgundy commented Oct 31, 2015

grunt-ts 5.1.0

When the overwriteFilesGlob option is set to true and the src option uses a variable itself, then updateFiles wont't work correctly
Gruntfile.js:

ts: {
      default: {
          tsconfig: {
            tsconfig: 'tsconfig.json',
            ignoreFiles: true,
            updateFiles: true,
            overwriteFilesGlob: true
          },
          src: ['<%= yeoman.app %>/scripts/**/*.ts', 'typings/tsd.d.ts']
      }
}

What ends up being written to tsconfig.json:

    "filesGlob": [
        "<%= yeoman.app %>/scripts/**/*.ts",
        "typings/tsd.d.ts"
    ],
    "files": [
        "typings/tsd.d.ts"
    ]

None of the 33 files that <%= yeoman.app %>/scripts/**/*.ts resolves are being written to tsconfig.json.
I believe overwriteFilesGlob should resolve any variables first before writing it to filesGlob.

@nycdotnet
Copy link
Contributor

Hi - sorry for the delay. I've been very busy with a new job and baby and a few other projects. I will try to look into this as soon as possible.

@nycdotnet
Copy link
Contributor

This is resolved via a warning in grunt-ts v5.3.0 which was just pushed to npm. Please comment or re-open if there are any remaining issues. Thank you for contributing! You're in the patch notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants