Questions about sourcemap

[imtaotao]

Why is the upstream sourcemap not processed in the loader?

https://github.com/TypeStrong/ts-loader/blob/main/src/index.ts#L34

function loader(this: webpack.LoaderContext<LoaderOptions>, contents: string, map?: Sourcemap) {
    if (map) {
       ...
    }
}

[johnnyreilly]

What processing did you have in mind?

[imtaotao]

I have a loader that processes source files, and then passes the source code and sourcemap to ts-loader, but ts-loader doesn't seem to merge the sourcemap passed from upstream loader.

[johnnyreilly]

What problems does that cause?

[chipzhang]

ts-loader/src/index.ts

Line 34 in 9533b2d

function loader(this: webpack.LoaderContext<LoaderOptions>, contents: string) {

Currently, ts-loader force discards any source maps generated by previous loaders.
In its exported loader entry function, it just silently ignores the third parameter, which is the source map returned by previous loaders.
If I have some pre-processor loaders running before ts-loader, it silently discards the source maps.
This is very bad.
You should at lease print a warning info, if the third parameter is not null.

[Ka0o0]

@johnnyreilly for us specifically this causes that we are not able to debug Vue SFC TypeScript files. This is because the ts-loader is the second loader after the vue-loader and should respect the input source maps generated by the vue-loader.

I've seen that there has already been made a suggestion on how to handle this: #1367 . I've tested the changes in one of our Vue projects and debugging works with those changes.