Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node engine V8 compatibility is broken #940

Closed
Borewit opened this issue Jan 12, 2020 · 3 comments · Fixed by #942
Closed

Node engine V8 compatibility is broken #940

Borewit opened this issue Jan 12, 2020 · 3 comments · Fixed by #942
Labels

Comments

@Borewit
Copy link

Borewit commented Jan 12, 2020

ts-node is no longer work on Node V8, because yn is enforcing Node V10 compatibility.
Caused by: yn#26

The motivation for changing the V8 requirement to V10 is because Node.js V8 is no longer supported. I believe node engine requirement should indicate the engine(s) the module works with.

@cspotcode
Copy link
Collaborator

I'm going to try wrapping the old version of yn in a wrapper that converts null return values to undefined. That should achieve the desired behavior without upgrading yn, which avoids the problematic engine requirement.

@cspotcode
Copy link
Collaborator

We can also add a yarn invocation to the test suite to catch the incompatibilities.

@cspotcode
Copy link
Collaborator

@Borewit @Darep yarn --ignore-engines should let you install in the meantime.

Our tests run on node 6 so everything should work once you get past the package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants