Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript 3.4 #1015

Closed
1 task done
fr0 opened this issue Apr 16, 2019 · 5 comments
Closed
1 task done

Support TypeScript 3.4 #1015

fr0 opened this issue Apr 16, 2019 · 5 comments

Comments

@fr0
Copy link

fr0 commented Apr 16, 2019

Problem

My app code uses globalThis, which is a new feature in TypeScript 3.4. Unfortunately, typedoc is using an old version of TS which doesn't know about it, and it breaks on my project.

Using TypeScript 3.2.4 from C:\ProgramData\Jenkins\workspace\atlas-dev-api\node_modules\typedoc\node_modules\typescript\lib
Error: C:/ProgramData/Jenkins/workspace/atlas-dev-api/src/step-identity.ts(12)
 Cannot find name 'globalThis'.

Suggested Solution

Upgrade TypeDoc to use the latest version of TypeScript.

@just-boris
Copy link
Contributor

The fix for this has already been merged ~2 weeks ago: #1014

We just need to ask maintainers about their plan to publish a release.

@nalply
Copy link

nalply commented May 10, 2019

TypeScript 3.4 const assertions seem not to work yet with the current version (0.15.0-0).

Error: /some-path/some-file.ts(11)
 Cannot find name 'const'.

for source like this

const composites = [ 'list', 'dir' ] as const

@fc
Copy link
Contributor

fc commented May 13, 2019

I'm also affected by a 3.4 issue that is described here:
microsoft/TypeScript#30153

Since master has already been version bumped to 3.4, if someone really needs it (like me...) you can do the following:

git clone https://github.com/TypeStrong/typedoc.git
cd typedoc
npm install

Then, generate the docs:

./bin/typedoc <path-to-your-project>

@shihlinlu
Copy link

Thanks @fc for the workaround. Does anyone know when the maintainers will publish the release to support 3.4?

@crhistianramirez
Copy link

This should be closed. Resolved here:
#1068

@fr0 fr0 closed this as completed Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants