Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid link when referencing the same local images from multiple doc locations #2627

Closed
obiot opened this issue Jul 7, 2024 · 2 comments
Closed
Labels
bug Functionality does not match expectation

Comments

@obiot
Copy link

obiot commented Jul 7, 2024

Search terms

img src invalid link

Expected Behavior

when referencing multiple time a "local" image from a repository, the generated typedoc should properly includes a link or a copy to the same image in all referenced documentation point.

Actual Behavior

Typedoc will copy the image under the destination folder renaming the file to imagename-[x]ext, and properly setting the link to the copied image for one of the reference, but letting the original imagename.ext filename for the other one.

Steps to reproduce the bug

here is an example where both use the same source image :

Link to our repo : https://github.com/melonjs/melonJS
tsconfig.json
tsconfig.base.json

Environment

  • Typedoc version: 0.26.3
  • TypeScript version: 5.5.2
  • Node.js version: 20.11.0
  • OS: MacOS 14.5
@obiot obiot added the bug Functionality does not match expectation label Jul 7, 2024
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jul 10, 2024

Well that's rather embarrassing, I just flat missed checking the cache if I had already generated a name for an image...

@obiot
Copy link
Author

obiot commented Jul 10, 2024

thanks for the fix !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality does not match expectation
Projects
None yet
Development

No branches or pull requests

2 participants