feat(common): Add Buffer support has returned value from an endpoint

Closes: #755
tsedio · Feb 6, 2020 · 406224d · 406224d
1 parent 165ca9d
commit 406224d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/common/src/mvc/builders/HandlerBuilder.ts b/packages/common/src/mvc/builders/HandlerBuilder.ts
@@ -102,7 +102,7 @@ export class HandlerBuilder {
         process = process.toPromise();
       }
 
-      if (isStream(process)) {
+      if (isStream(process) || Buffer.isBuffer(process)) {
         return done(null, process);
       }
 

diff --git a/packages/common/src/mvc/components/SendResponseMiddleware.ts b/packages/common/src/mvc/components/SendResponseMiddleware.ts
@@ -17,16 +17,24 @@ export class SendResponseMiddleware implements IMiddleware {
       return response.send();
     }
 
-    if (isStream(data)) {
+    if (this.shouldStream(data)) {
       data.pipe(response);
 
       return response;
     }
 
-    if (isBoolean(data) || isNumber(data) || isString(data) || data === null) {
+    if (this.shouldSend(data)) {
       return response.send(data);
     }
 
     return response.json(this.converterService.serialize(data, {type: endpoint.type}));
   }
+
+  protected shouldSend(data: any) {
+    return Buffer.isBuffer(data) || isBoolean(data) || isNumber(data) || isString(data) || data === null;
+  }
+
+  protected shouldStream(data: any) {
+    return isStream(data);
+  }
 }