Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos, mostly missing dots. #964

Merged
merged 1 commit into from Oct 7, 2020

Conversation

Zenigata
Copy link
Contributor

@Zenigata Zenigata commented Oct 6, 2020

Information

Type Breaking change
Doc No

Description

The ellipsis doesn't end a sentence. A dot does.

@Romakita
Copy link
Collaborator

Romakita commented Oct 7, 2020

Hello @Zenigata
Thanks for your PR ;)
Just one point before merging. Can you reword the commit message please.

docs: Fix some typos, mostly missing dots.

The CI use angular commits message convention to produce the release note :)

Thanks again ;)
See you and tell when it's down
Romain

@Zenigata
Copy link
Contributor Author

Zenigata commented Oct 7, 2020

My bad, you're right. Is it okay now?

@Romakita
Copy link
Collaborator

Romakita commented Oct 7, 2020

Perfect ;)

@Romakita Romakita merged commit 5bf47eb into tsedio:production Oct 7, 2020
@Romakita
Copy link
Collaborator

Romakita commented Oct 8, 2020

🎉 This PR is included in version 6.0.0-beta.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Romakita
Copy link
Collaborator

🎉 This PR is included in version 5.65.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants