feat(constructSignature): add construct signature #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uittorio
requested changes
Dec 3, 2019
uittorio
reviewed
Dec 3, 2019
| case ts.SyntaxKind.CallSignature: | ||
| return GetFunctionTypeDescriptor(node as ts.CallSignatureDeclaration, scope); | ||
| return GetFunctionTypeDescriptor(node as ts.CallSignatureDeclaration | ts.ConstructSignatureDeclaration, scope); |
There was a problem hiding this comment.
Ah sorry. I didn't see that you may still want to keep the switch case separated. Once you've done that you can remove the OR
There was a problem hiding this comment.
I put the OR there to make sure the typings are correct... if for some reason we change GetFunctionTypeDescriptor to only accept CallSignatureDeclaration it would give error... if I remove one of the two then there is no check anymore.
Do you want me to split the 2 cases of the switch?
uittorio
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to treat construct signature in the same way as call signature.
Something doesn't work perfectly but I think it's a non-problem:
is an accepted signature but my implementation can handle only constructions of object-like values.
Let me know if this concerns you