Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error when user provides an option/parameter that the command doesn't support #38

Closed
Tyrrrz opened this issue Jan 27, 2020 · 0 comments
Closed

Show error when user provides an option/parameter that the command doesn't support #38

Tyrrrz opened this issue Jan 27, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Tyrrrz
Copy link
Owner

Tyrrrz commented Jan 27, 2020

When the user supplies an unknown option/parameter, they should receive an error. This aligns with an optimal user experience, because the application shouldn't silently discard arguments that the user assumed would somehow change the behavior of the program.

Need to add a throw new CliFxException(...) statement somewhere in CommandSchema.InjectParameters and CommandSchema.InjectOptions.

Add corresponding tests.
@Tyrrrz Tyrrrz added enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2020
This was referenced Jan 27, 2020
Closed
Open
@Tyrrrz Tyrrrz closed this as completed in c854f5f Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tyrrrz