Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand the test suite to include (The failures found) by syntax checking php-src's phpt tests #4

Closed
TysonAndre opened this issue Mar 17, 2017 · 3 comments
Closed

Expand the test suite to include (The failures found) by syntax checking php-src's phpt tests #4

TysonAndre opened this issue Mar 17, 2017 · 3 comments

Comments

@TysonAndre
Copy link
Owner

php-ast's test suites are not comprehensive, and only cover major changes to the extension.
@TysonAndre TysonAndre mentioned this issue Mar 17, 2017
Closed
@TysonAndre
Copy link
Owner Author

Expanded this to errors found syntax checking phan and phan's tests

@TysonAndre
Copy link
Owner Author

A lot of this has been finished.

#11 and #10 are edge cases.

@TysonAndre
Copy link
Owner Author

Finished this. Noticed that goto, labels, doc comment on declares, etc. weren't tested, as well as some flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TysonAndre