Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer feedback from Group21 #67

Closed
chuangw6 opened this issue Jan 31, 2021 · 1 comment
Closed

Peer feedback from Group21 #67

chuangw6 opened this issue Jan 31, 2021 · 1 comment

Comments

@chuangw6
Copy link
Member

Hi, Group 22,
Hope you are doing great. This is frank from group 21. After looking at your proposal and the dashboard you have been working on, I am really interested in this project. Here is my feedback on your milestone2 release.

README.md file

  • As a potential user of your app, I really like the way you wrote the readme file. It has a clear structure and sections are well explained and organized.
  • For the screenshot that you included in the readme file, I think it would be great to include the screenshot of your real app interface instead of the prototype given that it was milestone2.
  • For the convenience of potential contributors who are interested in contributing to your project, it would be great to include the instructions on how they can run the app, and suggestions on what aspects they can contribute to for the project.

proposal.md file

This file looks great to me.

dashboard interface

  • It's great to see a lot of interactivities on all plots on your dashboard interface.
  • However, regarding usability, I think the appearance can be improved. For example,
    • the font of the two tabs could be bigger & bolded.
    • You can also add more white space between filters.
    • would be great if you add a side note to explain what the empty plots mean based on user selections (e.g. no data).

Thank you! Let me know if you have any questions or want to have a further discussion with me.

@sbabicki
Copy link
Collaborator

sbabicki commented Feb 7, 2021

Hi @chuangw46 , thank you for your feedback!

We have incorporated your feedback in the latest version of our app.

@sbabicki sbabicki closed this as completed Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants