Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 2 Review #36

Open
ericlee0920 opened this issue Dec 7, 2021 · 0 comments
Open

Milestone 2 Review #36

ericlee0920 opened this issue Dec 7, 2021 · 0 comments

Comments

@ericlee0920
Copy link

  1. Writing an analysis that uses multiple scripts: Accuracy [A]
  • Completed all requirements.
    1A. Code Quality [A-]
  • Lacking more detailed comments in preprocess_n_model.py
    1B. Mechanics [A+]
  • Did have 5 scripts.
    1C. Reasoning [B]
  • Your project has a lot of results. Try breaking the data down and explain the tables. There's a lack of interpretation in your report. Quantitatively explain your results using the entries in the tables.
  • Have a distinct summary or conclusion to lay out your findings.
    1D. Viz [A+]
  • Captions or explanation is present.
    1E. Writing [A+]
  • Included documentation on top of each file to scripts.
  1. Expectations: Mechanics [A+]
  • Git messages are meaningful. Commits are made.
    3A. Project organization and documentation expectations: Mechanics [B+]
    3B. Writing [A+]
  • Full sentences are used, less than 10% was in point form.
    3C. Reasoning [B]
  • Narrative of analysis and visualization was not present.
  • Lack of in depth analysis of EDA in the proposal readme. Should interpret the plot or give captions.
  • Did not see the evolution of proposal with short excerpts of major findings using your statistical method.
    4A. Submission expectations: Mechanics [A+]
  • URL was attached and release was created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant