Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single degree template - full catalog description modal can be rendered even if its toggle button is not #408

Open
cjg89 opened this issue Mar 31, 2022 · 0 comments

Comments

@cjg89
Copy link
Member

cjg89 commented Mar 31, 2022

Describe the bug

In the catalog_modal template part, it's possible for the description modal to be printed on the page even if the toggle button for said modal is not. This can ultimately result in content that is completely inaccessible to all users.

https://github.com/UCF/Main-Site-Theme/blob/7ab44c16b333f9d2d5ccf8e118b59d9faf8e386b/template-parts/degree/catalog_modal.php

Steps to Reproduce

See the Health Sciences (BS) – Pre-Clinical Track as an example. There are some scenarios in which we don't print the description or course_overview template part contents, and thus, don't print the catalog modal toggle button.

Expected Behavior

A catalog modal toggle button should always be rendered anywhere the modal itself is rendered.

Possible Fix

Not sure if the best course of action for this would be to remove the modal entirely in these scenarios, or to update logic somewhere to ensure a toggle button is always displayed when the modal is available. Needs feedback from Roger.

Your environment:

n/a

Additional context

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants