Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing error handling to throw runtime_error instead of string. #1131

Conversation

markus-jehl
Copy link
Contributor

No description provided.

@KrisThielemans
Copy link
Collaborator

Appveyor error was due to a bug introduced by myself. not sure why I hadn't seen it on Appveyor previously. It should be fixed in 63c2e9c

Please merge master in here (if the above commit worked). We'll also need some new release notes, but I wouldn't know what version to call it yet!

@markus-jehl
Copy link
Contributor Author

Perfect, thanks. I merged master now. Will be away all of next week, so you have a bit of time to work out the version number ;-)

@KrisThielemans
Copy link
Collaborator

@markus-jehl can you please merge master again, and update the release_5.2.htm?

@evgueni-ovtchinnikov will this affect SIRF? (depends on how you catch STIR exceptions). Maybe you can check SIRF with this branch?

@KrisThielemans KrisThielemans added this to the v5.2 milestone Feb 6, 2023
@markus-jehl
Copy link
Contributor Author

Done! The failed test is because some server appears to have been down.

@KrisThielemans
Copy link
Collaborator

Great. I re-ran the job and it's fine. waiting for @evgueni-ovtchinnikov's input.

@evgueni-ovtchinnikov
Copy link
Collaborator

I found exactly one occasion of catch(std::string msg) in SIRF and replaced it with catch(…), so I do not expect any SIRF problems with this PR merged.

@KrisThielemans
Copy link
Collaborator

thanks @evgueni-ovtchinnikov

@KrisThielemans KrisThielemans merged commit 0088020 into UCL:master Mar 8, 2023
@KrisThielemans KrisThielemans linked an issue Mar 8, 2023 that may be closed by this pull request
@markus-jehl markus-jehl deleted the issue/1130-error-throws-string-instead-of-runtime_error branch January 29, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error() function throws string instead of runtime_error
3 participants