New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing error handling to throw runtime_error instead of string. #1131
Changing error handling to throw runtime_error instead of string. #1131
Conversation
…the AppVeyor build with VS 13 compiler.
Appveyor error was due to a bug introduced by myself. not sure why I hadn't seen it on Appveyor previously. It should be fixed in 63c2e9c Please merge |
…throws-string-instead-of-runtime_error
Perfect, thanks. I merged master now. Will be away all of next week, so you have a bit of time to work out the version number ;-) |
@markus-jehl can you please merge @evgueni-ovtchinnikov will this affect SIRF? (depends on how you catch STIR exceptions). Maybe you can check SIRF with this branch? |
Done! The failed test is because some server appears to have been down. |
Great. I re-ran the job and it's fine. waiting for @evgueni-ovtchinnikov's input. |
I found exactly one occasion of |
thanks @evgueni-ovtchinnikov |
No description provided.