Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese pos tagset mapping #22

Merged
merged 5 commits into from Jan 10, 2022
Merged

Chinese pos tagset mapping #22

merged 5 commits into from Jan 10, 2022

Conversation

apmoore1
Copy link
Member

@apmoore1 apmoore1 commented Jan 8, 2022

Fixes #19

  1. Adds a mapping from the Penn Chinese Treebank POS tagset to USAS core POS tagset.
  2. In the documentation it clarifies that we used the Universal Dependencies Treebank version of the UPOS tagset rather than the original version from the paper by Petrov et al. 2012.

@apmoore1 apmoore1 requested a review from perayson January 8, 2022 11:35
@apmoore1 apmoore1 added the enhancement New feature or request label Jan 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2022

Codecov Report

Merging #22 (e5e33bf) into main (8344730) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files           8        8           
  Lines         335      336    +1     
  Branches       66       66           
=======================================
+ Hits          327      328    +1     
  Misses          7        7           
  Partials        1        1           
Impacted Files Coverage Δ
pymusas/pos_mapper.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8344730...e5e33bf. Read the comment docs.

@perayson perayson merged commit 854bce6 into main Jan 10, 2022
@perayson perayson deleted the chinese-pos-tagset-mapping branch January 10, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chinese Penn Treebank POS tagset mapping
3 participants