Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DatePicker): add getCalendarContainer to set popover container #110

Merged
merged 1 commit into from Apr 10, 2019

Conversation

ZxBing0066
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?
add DatePicker.getCalendarContainer to set popover container
add DatePicker.Range.popoverProps to set popover props
rename Select.popover to popoverProps
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

@ZxBing0066 ZxBing0066 added the feature New feature or request label Apr 10, 2019
@ZxBing0066 ZxBing0066 self-assigned this Apr 10, 2019
@ZxBing0066 ZxBing0066 added this to To do in Develop via automation Apr 10, 2019
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #110 into master will decrease coverage by 0.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   83.73%   83.72%   -0.02%     
==========================================
  Files         145      145              
  Lines        2601     2605       +4     
  Branches      594      620      +26     
==========================================
+ Hits         2178     2181       +3     
+ Misses        404      399       -5     
- Partials       19       25       +6
Impacted Files Coverage Δ
src/components/DatePicker/Range.jsx 47.76% <ø> (ø) ⬆️
src/components/Table/Table.jsx 73.75% <0%> (ø) ⬆️
src/components/Pagination/Options.jsx 95.12% <100%> (ø) ⬆️
src/components/Select/Select.jsx 90.36% <50%> (-1%) ⬇️
src/components/DatePicker/DatePicker.jsx 64.44% <66.66%> (+0.8%) ⬆️
src/components/DatePicker/Month.jsx 48% <66.66%> (+2.16%) ⬆️
src/components/Upload/Selector.jsx 11.11% <0%> (ø) ⬆️
src/components/Table/ResizableTH.jsx 63.63% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5e47bc...e219c9e. Read the comment docs.

@ZxBing0066 ZxBing0066 merged commit 3334611 into master Apr 10, 2019
Develop automation moved this from To do to Done Apr 10, 2019
@ZxBing0066 ZxBing0066 deleted the calendar-container branch April 10, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Develop
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant