Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): fix slider bug when update max min or step #112

Merged
merged 1 commit into from Apr 10, 2019

Conversation

ZxBing0066
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bug fix
What is the current behavior? (You can also link to an open issue here)
display wrong when update max min or step
What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

@ZxBing0066 ZxBing0066 added the bug Something isn't working label Apr 10, 2019
@ZxBing0066 ZxBing0066 self-assigned this Apr 10, 2019
@ZxBing0066 ZxBing0066 added this to To do in Develop via automation Apr 10, 2019
@codecov
Copy link

codecov bot commented Apr 10, 2019

Codecov Report

Merging #112 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
+ Coverage   83.73%   83.74%   +<.01%     
==========================================
  Files         145      145              
  Lines        2607     2608       +1     
  Branches      595      621      +26     
==========================================
+ Hits         2183     2184       +1     
+ Misses        405      399       -6     
- Partials       19       25       +6
Impacted Files Coverage Δ
src/components/Slider/Slider.jsx 97.3% <100%> (+0.01%) ⬆️
src/components/Upload/Selector.jsx 11.11% <0%> (ø) ⬆️
src/components/Table/ResizableTH.jsx 63.63% <0%> (ø) ⬆️
src/components/Table/Table.jsx 73.75% <0%> (ø) ⬆️
src/components/DatePicker/Range.jsx 47.76% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031d7ea...d721280. Read the comment docs.

@ZxBing0066 ZxBing0066 merged commit 93fd186 into master Apr 10, 2019
Develop automation moved this from To do to Done Apr 10, 2019
@ZxBing0066 ZxBing0066 deleted the slider-fix branch April 10, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Develop
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant