Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table): add columnPlaceholder #194

Merged
merged 2 commits into from Jan 3, 2020
Merged

feat(Table): add columnPlaceholder #194

merged 2 commits into from Jan 3, 2020

Conversation

ZxBing0066
Copy link
Contributor

add columnPlaceholder for auto placehold with & clone table to local

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • Follow our contributing docs
  • Docs have been added/updated
  • Tests have been added; existing tests pass

Other information:

add columnPlaceholder for auto placehold with & clone table to local
@ZxBing0066 ZxBing0066 added the feature New feature or request label Jan 3, 2020
@ZxBing0066 ZxBing0066 self-assigned this Jan 3, 2020
@ZxBing0066 ZxBing0066 added this to To do in Develop via automation Jan 3, 2020
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #194 into master will decrease coverage by 3.35%.
The diff coverage is 66.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
- Coverage   84.11%   80.75%   -3.36%     
==========================================
  Files         159      175      +16     
  Lines        2801     3456     +655     
  Branches      625      812     +187     
==========================================
+ Hits         2356     2791     +435     
- Misses        421      583     +162     
- Partials       24       82      +58
Impacted Files Coverage Δ
src/libs/rc-table/index.js 100% <100%> (ø)
src/components/Table/style/index.js 96% <100%> (+0.34%) ⬆️
src/libs/rc-table/ColGroup.js 100% <100%> (ø)
src/libs/rc-table/Column.js 100% <100%> (ø)
src/libs/rc-table/Table.js 40.6% <40.6%> (ø)
src/components/Table/Table.jsx 72.82% <42.85%> (-0.88%) ⬇️
src/libs/rc-table/utils.js 52.38% <52.38%> (ø)
src/libs/rc-table/TableRow.js 56.32% <56.32%> (ø)
src/libs/rc-table/ExpandableTable.js 66.15% <66.15%> (ø)
src/libs/rc-table/ExpandableRow.js 67.85% <67.85%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1d626...6c4c53f. Read the comment docs.

@ZxBing0066 ZxBing0066 merged commit d9dbfa1 into master Jan 3, 2020
Develop automation moved this from To do to Done Jan 3, 2020
@ZxBing0066 ZxBing0066 deleted the table-clone branch January 3, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Develop
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant